Upgrade to hardhat 3 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnarvaja
approved these changes
Jan 21, 2026
| await currency.connect(admin).mint(anon, _A(100)); | ||
| expect(await currency.balanceOf(anon)).to.equal(_A(10100)); | ||
| await expect(currency.connect(admin).burn(anon, _A(150))).not.to.be.reverted; | ||
| await currency.connect(admin).burn(anon, _A(150)); |
Contributor
There was a problem hiding this comment.
Ya no hay not.to.be.reverted? O lo sacaste porque igual si revierte va a fallar el test igual?
Contributor
Author
There was a problem hiding this comment.
Ahora es not.to.revert, pero no tenía mucho sentido porque si revierte el test va a fallar y tirar el stack del revert.
El assertion por algún motivo no estaba haciendo await de la transacción, entonces el assert posterior del balance fallaba, con este cambio se soluciona.
Es similar a este issue: NomicFoundation/hardhat#4725
Pero nosotros estamos en la versión 3.0.2 de chai-matchers, debería estar corregido. Tengo que reportarlo.
gnarvaja
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.